[tor-bugs] #13788 [Tor Browser]: Meek bridges don't work in TB 4.5alpha1

[Tor Bug Tracker & Wiki]

#13788: Meek bridges don't work in TB 4.5alpha1
-----------------------------+----------------------
     Reporter:  cypherpunks  |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  meek
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------

Comment (by dcf):

 Replying to [comment:14 arthuredelstein]:
 > Replying to [comment:13 dcf]:
 > [snip]
 > > It seems that previously the code used `!mProxyHost.IsEmpty()` as the
 signal for a proxy being set, not merely `mProxyHost` being true. Maybe
 that old condition should be restored?
 > > https://gitweb.torproject.org/tor-
 browser.git/diff/netwerk/base/src/nsSocketTransport2.h?h=tor-
 browser-31.2.0esr-4.5-1&id=e0eaf6b471ae3bbc06066232a00f3b27c2bedeee
 >
 > I'm posting a fixup here that simplifies that patch (e0eaf6b4) and
 restores the use of `!mProxyHost.IsEmpty()` in nsSocketTransport2.*. I did
 this work in trying to get the patch to land in mozilla-central (still
 working on that). The patch works for domain isolation, but I haven't had
 a chance to test it with meek. If anyone wants to give it a try, let me
 know if this helps.

 Thanks, Arthur. I'm starting a build that includes attachment:0001-fixup-
 Bug-3455.2.-Allow-RFC1929-authentication-usern.patch. (I did "git am" of
 the patch in tor-browser.git on top of [https://gitweb.torproject.org/tor-
 browser.git/commit/?h=esr24&id=tor-browser-31.3.0esr-4.5-1-build1 tor-
 browser-31.3.0esr-4.5-1-build1] and then set "VERIFY_TAGS=0" and
 "TORBROWSER_TAG=''commit hash after git am''" in versions.alpha.) I'll
 test it and see how it works.

 If you want to try yourself, it's pretty easy (doesn't need bridge
 addresses). See
 https://trac.torproject.org/projects/tor/wiki/doc/meek#Quickstart. If
 bootstrapping gets past 10%, that means it's working.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13788#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online