[tor-bugs] #13827 [Tor]: Cell handling code duplication in channel.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Dec 3 14:37:45 UTC 2014
#13827: Cell handling code duplication in channel.c
------------------------+------------------------------
Reporter: rl1987 | Owner: rl1987
Type: defect | Status: accepted
Priority: normal | Milestone: Tor: unspecified
Component: Tor | Version:
Resolution: | Keywords: refactoring easy
Actual Points: | Parent ID:
Points: |
------------------------+------------------------------
Comment (by nickm):
Probably the best way to handle this would be to figure out how and
whether cell_t, var_cell_t, and packed_cell_t can (or should) be merged
into a single type, and/or to look at dataflow to see if some of those
functions can be rewritten to use the others instead.
One wrinkle here is that the *cell_t types need to be very efficient;
every piece of data that Tor transmits goes through one of them.
As for eliminating duplicate code in general: I think it's a higher
priority to do it for larger functions, and proportionally less valuable
to do it for smaller functions.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13827#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list