[tor-bugs] #12651 [Onionoo]: Details documents of non-running nodes may contain "running":true

[Tor Bug Tracker & Wiki]

#12651: Details documents of non-running nodes may contain "running":true
-------------------------+--------------------------
     Reporter:  karsten  |      Owner:  karsten
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------

Comment (by karsten):

 Cool, thanks for the review!  Let's first agree how to handle the hostname
 hack, and then squash, merge, deploy, and hope for the best.

 To be honest, I don't like the hostname hack very much.  But I wrote it,
 because I wanted to add as little temporary code as possible.  And I
 figured this hack is okay, because a) host names are newly resolved after
 12 hours after which nobody will figure out there was a hack, b) there's a
 yet unknown bug with host names in master (3270 of the current details
 files using master have a host_name field, compared to 9290 files on the
 mirror running the new branch), c) neither Atlas nor Globe show the
 hostname.

 But let's talk about alternatives, also for the next time when we plan to
 deploy a hack like this: we could go through all node statuses and write
 their host names to details status files.  That's probably another 10
 lines of code which will only be executed once.  Though we should probably
 test them before we deploy them.  What do you think?

 Your other suggestions all make sense and we should implement them all
 after merging this branch.  The only thing that I'm not certain about yet
 is the debug log line whenever we silently exit a method.  I'd rather
 postpone adding new debug log statements until we define common guidelines
 for when to log on what level.  Adding a code comment seems very
 reasonable, though.  I can make these changes after merging the other
 stuff to master, unless you'd rather want to make them.  Let me know.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12651#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online