[tor-bugs] #12606 [Pluggable transport]: Refactor obfs4proxy (and the support protocol code)

[Tor Bug Tracker & Wiki]

#12606: Refactor obfs4proxy (and the support protocol code)
-------------------------------------+--------------------------
     Reporter:  yawning              |      Owner:  yawning
         Type:  defect               |     Status:  needs_review
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  obfs4
Actual Points:                       |  Parent ID:  #12130
       Points:                       |
-------------------------------------+--------------------------

Comment (by yawning):

 Replying to [comment:7 yawning]:
 > Replying to [comment:6 asn]:
 > > Also that ERROR "handshake failed" is probably someone who
 disconnected during the handshake, not something more serious, right?
 >
 > Probably, but because of the log scrubbing that I had to put in, it'll
 suppress the more interesting errors unless the log scrubber is disabled,
 so there's no way to tell at the moment.  I'll revise the code to only
 suppress go network errors and see if that's better.

 https://gitweb.torproject.org/pluggable-
 transports/obfs4.git/commitdiff/ce39988b11a56e763c8eedbbdab75a35b48366d4

 I did a bit better and wrote a sanitizer for common net.Error types.  If
 it gets passed a net.Error that it doesn't know about, it will pring
 `network error: <TYPE OF ERROR>` which is less than ideal, but I covered
 most of the likely ones, and what the user is probably most interested in
 are protocol errors (unsanitized) and `net.OpError`s (handled).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12606#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online