[tor-bugs] #12606 [Pluggable transport]: Refactor obfs4proxy (and the support protocol code)

[Tor Bug Tracker & Wiki]

#12606: Refactor obfs4proxy (and the support protocol code)
-------------------------------------+--------------------------
     Reporter:  yawning              |      Owner:  yawning
         Type:  defect               |     Status:  needs_review
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  obfs4
Actual Points:                       |  Parent ID:  #12130
       Points:                       |
-------------------------------------+--------------------------

Comment (by asn):

 Also, it would be nice if obfs4proxy's logging was less heavy volume.
 attachment:obfs4_conns.log has a sample of what the logs look like in my
 bridge.

 As a bridge op, I regularly check obfspoxy logs to see if any new
 handshake log warnings have triggered (perhaps active scanning?), but if
 the log is so busy it's easy to lose information. Log severities or more
 strategic logging would be helpful.

 Also that ERROR "handshake failed" is probably someone who disconnected
 during the handshake, not something more serious, right?

 fwiw I still haven't reviewed your new changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12606#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online