[tor-bugs] #12985 [Tor]: call tor_event_free, not tor_free, on events in connection_free().

[Tor Bug Tracker & Wiki]

#12985: call tor_event_free, not tor_free, on events in connection_free().
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:
     Type:  defect                               |         Status:  new
 Priority:  normal                               |      Milestone:  Tor:
Component:  Tor                                  |  0.2.6.x-final
 Keywords:  tor-relay 025-backport 024-backport  |        Version:
Parent ID:                                       |  Actual Points:
                                                 |         Points:
-------------------------------------------------+-------------------------
 In `connection_free_`, we do a probably-redundant call to tor_free on
 conn->read_event and conn->write_event.

 This tor_free() is redundant (as we note in a comment) whenever we're
 calling `connection_free_` from `connection_free`.  But in one case -- the
 case where we're running connection_free_all -- we might get into trouble.
 We could free the event without first running event_del() on it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12985>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online