[tor-bugs] #12955 [Tor]: New tests for routerset.c

[Tor Bug Tracker & Wiki]

#12955: New tests for routerset.c
-----------------------------+--------------------------------
     Reporter:  _x3j11       |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by _x3j11):

 I've added a new version of the patch. This version
 * adds comments to all tests, specifically noting whether a test is
 functional (blackbox), or structual (whitebox).
 * does not add the -g flag from include.am
 * weakens the tests for routerset_new and routerset_free, specifically,
 only testing whether the members of the routerset are non-null and only
 tests that the *_free functions are called a nonzero amount of times. (I
 think those were the only real instances of overfitting in the test suite,
 but let me know if something else looks objectionable.)

 Let me know if there's anything else you think that needs improvement.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12955#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online