[tor-bugs] #12956 [arm]: arm mistakenly calls the last hop of internal circuits the Exit

[Tor Bug Tracker & Wiki]

#12956: arm mistakenly calls the last hop of internal circuits the Exit
--------------------+------------------------
 Reporter:  arma    |          Owner:  atagar
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:
Component:  arm     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------
 Every so often we have concerned users thinking they misconfigured their
 relay's exit policy, since in arm they see circuits that end at their
 relay and whose final hop is labelled 'Exit'.

 E.g.:
 {{{
 arm - last-request (Linux 3.2.0-4-amd64)   Tor 0.2.5.6-alpha (recommended)
 Relaying Disabled, Control Port (open): 9051
 cpu: 0.0% tor, 0.8% arm    mem: 29 MB (0.8%)   pid: 6395   uptime:
 1-20:40:44

 page 2 / 5 - m: menu, p: pause, h: page help, q: quit
 Connections (2 circuit):
  76.99.61.63            -->  188.138.17.248 (fr)               3.1m
 (CIRCUIT)
  │  83.168.200.204 (se)      ParadiseTorRelay1                   1 / Guard
  │  18.181.5.37 (us)         VERITAS                             2 /
 Middle
  └─ 188.138.17.248 (fr)      EuropeCoastDE                       3 / Exit
  76.99.61.63            -->  209.159.130.6 (us)                3.1m
 (CIRCUIT)
  │  83.168.200.204 (se)      ParadiseTorRelay1                   1 / Guard
  │  213.138.110.88 (gb)      lupine                              2 /
 Middle
  └─ 209.159.130.6 (us)       LiveFreeOrDie                       3 / Exit
 }}}

 I think for non-general-purpose circuits, we should call that third hop
 something else. I'm open to suggestions -- one option would be to just
 call the last hop on a non-exit circuit "Middle" also. Another option
 would be to call it "Internal".

 Specifically, we could apply this new name to everything with circuit
 purpose other than GENERAL. Or we could apply it to all circuits that have
 the IS_INTERNAL flag. Maybe the latter approach is a bit more general.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12956>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online