[tor-bugs] #3455 [Tor Browser]: Tor Browser should set SOCKS username for a request based on first party domain

[Tor Bug Tracker & Wiki]

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  mikeperry              |     Status:  needs_review
         Type:           |  Milestone:  TorBrowserBundle 2.3.x-stable
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-linkability, tbb-usability,
    Component:  Tor      |  MikePerry201408R, TorBrowserTeam201408, tbb-
  Browser                |  firefox-patch
   Resolution:           |  Parent ID:  #5752
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 I forgot to explain my last updates to Patches 1/3 and 3/3 on 2014-08-07.

 The commit message for Part 1/3 is:

     This patch adds an alternative to the nsIProtocolProxyFilter
     mechanism, called nsIProtocolProxyChannelFilter, in which
     a protocol proxy filter receives a channel object rather than
     a URI. Access to the channel object allows the proxy filter to
     provide proxy settings according to the URL bar domain.

 In this version, I'm retaining the original nsIProtocolProxyFilter
 interface, to avoid breaking SSL Observatory and any other existing
 extensions. I hope this means it will be easier to get Mozilla to accept
 this patch.

 The new version of Patch 3/3 (DomainIsolator) implements the new
 nsIProtocolProxyChannelFilter to get a reference to the channel and
 thereby obtain the URL bar domain for tor circuit isolation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online