[tor-bugs] #12205 [Tor]: Document magic numbers at entry_is_time_to_retry()

[Tor Bug Tracker & Wiki]

#12205: Document magic numbers at entry_is_time_to_retry()
-------------------------+--------------------------------
     Reporter:  asn      |      Owner:  rl1987
         Type:  defect   |     Status:  needs_review
     Priority:  trivial  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-guard
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by nickm):

 quick review:

 1) Why did this go away?
 {{{
 -  if (e->last_attempted < e->unreachable_since)
 -    return 1;
 }}}

 2) There's no advantage to using 'short' here.

 3) Yeah, it should probably have a quick test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12205#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online