[tor-bugs] #12218 [EFF-HTTPS Everywhere]: toolbar_button.js should do more null checks (was: No rules show up after installing HTTPS Everywhere)

[Tor Bug Tracker & Wiki]

#12218: toolbar_button.js should do more null checks
--------------------------------------+----------------------------
     Reporter:  cypherpunks           |      Owner:  zyan
         Type:  defect                |     Status:  needs_revision
     Priority:  minor                 |  Milestone:
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:                        |   Keywords:  rulesets
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+----------------------------
Changes (by jsha):

 * priority:  critical => minor
 * status:  needs_information => needs_revision


Comment:

 I tried to reproduce this on Firefox 31.0. I installed HTTPS Everywhere,
 restarted, customized the toolbar to remove the HTTPS Everywhere icon, and
 restarted. I was still able to visit e.g. httP://www.openssl.org, and get
 redirected by the extension to HTTPS.

 I'm not sure what's going on, but I do notice a few places in
 toolbar_button.js that could you some protective null checks. I'm going to
 downgrade priority and rename.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12218#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online