[tor-bugs] #9971 [Tor]: for_discovery option in add_an_entry_guard() is confusingly named

[Tor Bug Tracker & Wiki]

#9971: for_discovery option in add_an_entry_guard() is confusingly named
------------------------+--------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client easy refactor
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------------

Comment (by nickm):

 asn, does this conflict with the guard refactoring stuff you're doing?  If
 so, couple you please incorporate the first two as feasible?  These
 patches seem like reasonably good ideas to me.

 The third one makes me nervous: we should still probably be appending the
 stuff in EntryNodes, right?  Otherwise I worry we'll change our guards too
 fast.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9971#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online