[tor-bugs] #12716 [meek]: Make meek-client-torbrower take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrower take the firefox command as a parameter
------------------------+-----------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------

Comment (by dcf):

 attachment:0001-Add-firefox-and-profile-options-to-meek-client-
 torbr.patch​ adds --firefox and --profile options to meek-client-
 torbrowser. I'm not sure that's the best way to go. It looks like this:
 {{{
 ./meek-client-torbrowser --firefox ./firefox --profile
 TorBrowser/Data/Browser/profile.meek-http-helper -- ./meek-client
 }}}

 I thought of passing both complete commands as strings, like
 {{{
 ./meek-client-torbrowser --firefox "./firefox -no-remote -profile
 TorBrowser/Data/Browser/profile.meek-http-helper" --meek-client "./meek-
 client"
 }}}
 But then there would need to be code to split up a quoted string, and I'm
 not sure I want that. Also I think tor might split up a
 ClientTransportPlugin line on whitespace, and chop up the quoted strings.

 Another option is to slightly abuse -- as an additional separator between
 the firefox command and the meek-client command:
 {{{
 ./meek-client-torbrowser -- ./firefox -no-remote -profile
 TorBrowser/Data/Browser/profile.meek-http-helper -- ./meek-client
 }}}
 You can get away with that because firefox doesn't use --.

 But there's an additional problem with passing a complete firefox command
 line. Mac OS X needs an absolute path for the profile directory, so meek-
 client-torbrowser absolutizes it. It couldn't do that easily if the whole
 command were to come as a unit.
  * https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/7e65827d2fd1332e4d670493e860fabf0f0e06c0:/meek-
 client-torbrowser/meek-client-torbrowser.go#l77

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online