[tor-bugs] #12684 [Firefox Patch Issues]: Make "Not Now" the default button for TorBrowser's canvas permission dialogue

[Tor Bug Tracker & Wiki]

#12684: Make "Not Now" the default button for TorBrowser's canvas permission
dialogue
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_review
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-usability, tbb-
   Resolution:                       |  linkability, MikePerry201407R,
Actual Points:                       |  TorBrowserTeam201407
       Points:                       |  Parent ID:
-------------------------------------+-------------------------------------

Comment (by isis):

 Okay, here's what my current problems are, and what the UI looks like:

 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/12684/torbrowser-canvas-fingerprinting-UI_1.jpg)]]

 Problem !#1: That `<separator class="groove">` part between the sentences.
 For the life of me, I can't get this thing to insert a newline. I've tried
 `\n\n`, a [https://developer.mozilla.org/en-
 US/docs/Mozilla/Tech/XUL/separator XUL separator] and a
 [https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/spacer XUL
 spacer]. All of them actually show up in the text.

 Problem !#2: The `Not Now` thing is duplicated, as gk pointed out.
 Patching this would be a giant mess and would require more Firefox
 patches. I could make the `Never for this site` be the default, and get
 rid of the first `Not Now`, if people think that `Never` is an okay
 default.

 -------

 I've also added a freely-licenced icon for this popup, to replace the
 question mark, but that was more Firefox patches and I haven't rebuilt
 yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12684#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online