[tor-bugs] #11553 [Tor]: Be more verbose when warning about not finding a circuit ID

[Tor Bug Tracker & Wiki]

#11553: Be more verbose when warning about not finding a circuit ID
-------------------------+-------------------------------------------------
     Reporter:  ra       |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.4.x-final
     Priority:  major    |    Version:  Tor: 0.2.5.3-alpha
    Component:  Tor      |   Keywords:  tor-relay, 024-backport,
   Resolution:           |  023-backport, andrea-review-0254, 025-triaged,
Actual Points:           |  nickm-backport-02422
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by arma):

 Are you proposing to backport bug11553_024, i.e. with the new randomized
 circid selection? That sure seems like a feature to me ("it uses less cpu,
 especially in edge cases").

 That said, I could get behind the very precision oriented change:
 {{{
 -      log_warn(LD_CIRC,"No unused circ IDs. Failing.");
 +      log_warn(LD_CIRC,"No unused circIDs found on channel %s wide "
 +               "circID support, with %u inbound and %u outbound circuits.
 "
 +               "Failing a circuit.",
 +               chan->wide_circ_ids ? "with" : "without",
 +               chan->num_p_circuits, chan->num_n_circuits);
 }}}

 That way, if an 0.2.4.x relay operator hits this case again, we'll have
 more details than we had before. What would you think of that?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11553#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online