[tor-bugs] #11558 [Obfsproxy]: obfsproxy breaks with old versions of twisted

[Tor Bug Tracker & Wiki]

#11558: obfsproxy breaks with old versions of twisted
---------------------------+--------------------------------------
     Reporter:  yawning    |      Owner:  asn
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:
   Resolution:             |   Keywords:  debian, twisted, ancient
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+--------------------------------------

Comment (by asn):

 Replying to [comment:6 asn]:
 > Replying to [comment:5 yawning]:
 > > Hmm even if you make txsocksx optional there still needs to be code
 for handling Twisted versions that don't have
 `twisted.internet.error.UnsupportedAddressFamily`.  Instead of in
 `__init__.py` this could be done in `socks5.py` since that's the only
 place that uses that exception.
 > >
 > > Since it's just error handling, we could also change the code to
 sending a SOCKS5 General Failure error for `EAFNOSUPPORT`, but that seems
 less optimal for people that do have recent versions of Twisted.
 >
 > Good point. That's a problem with the SOCKS server not the SOCKS client
 anymore.
 >
 > Please check my branch `bug11558_optional_deps` again. I'm planning to
 test that branch later today or tomorrow.

 `UnsupportedAddressFamily` test worked fine.

 I started up Tor with obfsproxy in an oldstable system, and tried to
 connect to a non-existent bridge.
 Without `d7d7570` I get:
 {{{exceptions.AttributeError: 'module' object has no attribute
 'UnsupportedAddressFamily'}}}
 With `d7d7570`, it seems to work fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11558#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online