[tor-bugs] #9308 [Firefox Patch Issues]: JavaScript's BrowserFeedWriter() leaks installation paths on OS X and Windows

[Tor Bug Tracker & Wiki]

#9308: JavaScript's BrowserFeedWriter() leaks installation paths on OS X and
Windows
-------------------------------------+-------------------------------------
     Reporter:  cypherpunks          |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_review
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-fingerprinting,
   Resolution:                       |  tbb-easy, interview,
Actual Points:                       |  GeorgKoppen201404R,
       Points:                       |  MikePerry201404R
                                     |  Parent ID:
-------------------------------------+-------------------------------------

Comment (by mikeperry):

 I found a memory leak in this patch. The rawFilename string gets allocated
 by aLocation->GetFilename() and is never freed. I also added some (likely
 redundant) additional checks to Omnijar::RebaseFilename() for safety.
 Fixup patch will be attached next.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9308#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online