[tor-bugs] #8793 [Tor]: Resolve clang scan-build issues

[Tor Bug Tracker & Wiki]

#8793: Resolve clang scan-build issues
------------------------+------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client 025-triaged
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by nickm):

 On review, I don't see any actual errors outside the tests, but I do see
 some functions that in isolation are wrong; some BUG messages that could
 crash if they ever triggered (in ways I think are impossible), and some
 code that could be more obviously correct.

 I've started work on a branch to fix those.  Then I'm going to re-run with
 all the interesting alpha checkers turned on and see whether it crashes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8793#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online