[tor-bugs] #9957 [Tor]: Tor should consider stderr output of transport proxies

[Tor Bug Tracker & Wiki]

#9957: Tor should consider stderr output of transport proxies
------------------------+--------------------------------
     Reporter:  wfn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by wfn):

 Replying to [comment:9 wfn]:
 > Replying to [comment:7 asn]:
 >
 >
 > > Patch looks plausible.
 > >
 > > Three comments:
 > > a) `configure_proxy()` is getting pretty big. Maybe move stderr
 reading to a function, and call it from `configure_proxy()`?
 >
 > Hmm, it's not *that* big
 ([https://github.com/wfn/tor/blob/bug_9957/src/or/transports.c#L591-L698
 ~100 lines]), but I see what you mean - it's doing multiple things, so to
 say. There's some global state involved (e.g. we need to free
 `proxy_err_output` at a particular point dependent on the status of the
 stdout stream), so it might not be as clean as you'd like - but see
 attached patch.

 On second thought, I was wrong, what 'global state'. Flow is simple. Will
 probably attach another patch once I get the chance to compile tor again
 (afk/computer now.) Sorry for verbosity!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9957#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online