[tor-bugs] #10887 [Obfsproxy]: ScrambleSuit should make it easy for bridge admins to learn password

[Tor Bug Tracker & Wiki]

#10887: ScrambleSuit should make it easy for bridge admins to learn password
-------------------------+-------------------------------------------------
     Reporter:  phw      |      Owner:  phw
         Type:           |     Status:  needs_revision
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:           |   Keywords:  scramblesuit, password, shared
  Obfsproxy              |  secret
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by asn):

 For example this change makes it work (int tests pass):
 {{{
 --- a/obfsproxy/transports/scramblesuit/scramblesuit.py
 +++ b/obfsproxy/transports/scramblesuit/scramblesuit.py
 @@ -129,7 +129,7 @@ class ScrambleSuitTransport( base.BaseTransport ):

                  cls.uniformDHSecret = cls.uniformDHSecret.strip()

 -        if cls.weAreServer:
 +        if cls.weAreServer and not cls.weAreExternal:
              if not hasattr(cls, "uniformDHSecret"):
                  log.debug("Using fallback password for descriptor file.")
                  srv = state.load()
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10887#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online