[tor-bugs] #8787 [Tor]: Check return values for more unix functions

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 1 23:52:28 UTC 2014


#8787: Check return values for more unix functions
------------------------+------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.???
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client 025-triaged
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------
Changes (by andrea):

 * milestone:  Tor: 0.2.5.x-final => Tor: 0.2.???


Comment:

 For strftime, I think the only likely cause of failures is output too
 large for the buffer, and it's too big a refactor to check the returns in
 0.2.5.  I'm sending this to 0.2.?? for now, and at some point we should do
 one of the following:

 1.) Refactor so we can check strftime() returns

 or

 2.) Audit each call and be sure the buffer is always large enough, and
 then decide that suffices and close this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8787#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list