[tor-bugs] #2454 [Tor]: We should check our IP immediately when cbt notes the network is live again

[Tor Bug Tracker & Wiki]

#2454: We should check our IP immediately when cbt notes the network is live again
-----------------------------+-----------------------------------
     Reporter:  Sebastian    |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay 025-triaged
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by nickm):

 Replying to [comment:15 andrea]:
 > > 4) Can this fire more than once every 3 minutes?
 >
 > Do you mean you think three minutes is *too long* and we should recheck
 sooner, or you're worried it might run too often and if it did something
 it runs would either be too expensive or not idempotent?

 The latter.

 > > 5) Is there anything in that big block in main.c that we *don't* want
 to do in this case?
 >
 > It looks like most of that stuff has checks to stop it running too
 often, but check_descriptor_ipaddress_changed() starts DNS queries in some
 cases and routerlist_remove_old_routers() has a for loop over
 routerlist->routers - might be worth limiting how often that runs.

 I think burning some CPU if this gets out of hand isn't too bad -- I think
 the bad thing would be if we were spamming descriptors to the directory
 servers or something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2454#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online