[tor-bugs] #9830 [Tor bundles/installation]: mingw-w64 compilation of Firefox 24 ESR is broken

[Tor Bug Tracker & Wiki]

#9830: mingw-w64 compilation of Firefox 24 ESR is broken
------------------------------------------+-------------------------------
     Reporter:  gk                        |      Owner:  erinn
         Type:  defect                    |     Status:  needs_review
     Priority:  normal                    |  Milestone:
    Component:  Tor bundles/installation  |    Version:
   Resolution:                            |   Keywords:  tbb-3.0, ff24-esr
Actual Points:                            |  Parent ID:  #9827
       Points:                            |
------------------------------------------+-------------------------------
Changes (by gk):

 * status:  new => needs_review


Comment:

 https://hg.mozilla.org/mozilla-central/rev/7b86302ab2b3
 https://hg.mozilla.org/mozilla-central/rev/1651ea86cb00
 https://hg.mozilla.org/mozilla-central/rev/fda0046aa376
 https://hg.mozilla.org/mozilla-central/rev/02d4ae55e1c3

 need to get merged in order to fix the breakage due to mingw-w64 being no
 tier-1 compiler for Mozilla. The last changeset might even be relevant for
 the TBB 2.x series (if it ever ships a Firefox 24) as I don't have a clue
 (and Jacek neither) how Firefox 24 could ever get built for Windows
 without it (maybe some MSVC, well, feature...).

 The attached file fixes the mingw-w64 "internal" error as rev 5830 is not
 sufficient anymore to build ESR 24. We need at least 5880. I chose 6184
 for the following reasons: 1) I built a lot with that revision when trying
 to solve the _strcmpi issue in #9084 and never had an issue. Thus, it is
 pretty stable. 2) rev 6184 contains the fix for the _strcmpi issue. Thus,
 if that one is indeed just an issue in our setup it can be solved without
 bumping the mingw-w64 revision again (assuming we would chose, say 5880,
 for resolving this bug). Granted, every rev > 6184 would be fit for this
 purpose as well. But I have not tested any so far in order to check
 whether they build Firefox at all...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9830#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online