[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 25 14:51:28 UTC 2013


#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by andrea):

 Replying to [comment:12 nickm]:
 > Okay, is this something that has a fix, or do we need a different
 approach for this patch?

 Not sure yet; need to check into whether there's actually any good reason
 for n_chan/p_chan to still be set after circuit_mark_for_close_() or it's
 just a historical accident.  If the latter, then the easy fix is to set
 them to NULL immediately after calling circuitmux_detach_circuit().

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list