[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by andrea):

 Actually, there's another bug here: there exist a few circumstances where
 a circuit is not attached to its channel's mux but still has n_chan/p_chan
 set.  Specifically, if the circuit is marked for close (see the
 circuitmux_detach_circuit() calls in circuit_mark_for_close_() which was
 the case I just observed this for), and briefly during
 circuit_set_circid_chan_helper() (but I don't think there's any way for
 this to be called in that interval).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online