[tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 24 15:58:53 UTC 2013


#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by dcf):

 > Replying to [comment:7 dcf]:
 > > `make install` was a sticking point the last time, too. Maybe we
 should just remove the `install` target? It can't be that very many people
 are using `make install` or even using the client packages. Or do you need
 `make install` for the Debian package?
 > >
 > > Your idea of using `setup.py` only for installing the library was a
 good one. It avoids the bugs we found earlier in trying to use `setup.py`
 to install binaries and man pages, and to build tarballs. Can we just do
 the `python setup.py install` thing on `make install` automatically? I
 know it's possible to pass the bindir and destdir in this way.
 >
 > Yes, that's fine, and here we are going into packaging territory so I've
 written some more background info FYI on #9668

 Sure, but understand I can't merge a patch that breaks `make install`,
 unless we also decide to jettison `make install`. Could you try having
 `setup.py` called automatically? My first concern is ease-of-use from the
 end-user's point of view. Ease for packagers is still important but
 secondary. That is, I would rather have `make install` take one command
 and packaging take two commands, than the other way around.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list