[tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 24 15:50:29 UTC 2013


#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by dcf):

 Replying to [comment:8 infinity0]:
 > Replying to [comment:6 dcf]:
 > > Can you explain the purpose and benefits of the versioneer library?
 > >
 >
 > It automates version numbers from git tags, so you don't need to keep
 editing the version file. It generates versions like 1.3+git1fce958 (like
 `git describe`) for non-tag commits. I copied the idea over from
 obfsproxy.

 Okay. I wonder, could we deal with the versioneer issue in a separate
 patch/ticket? The factoring of functions into packages is very close to a
 slam dunk. The addition of a new largish third-party source file is less
 obviously a slam dunk. Also it's nice if a deduplication branch ends up
 with a net loss of lines of code.

 I'm relatively open to the idea of using versioneer, but as I say, could
 we deal with it separately? It appears there may be a technical obstacle
 in communicating the version number to `setup.py` from `Makefile`, but
 maybe you have an idea for how to deal with that?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list