[tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 24 02:23:05 UTC 2013


#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by dcf):

 Can you explain the purpose and benefits of the versioneer library?

 I wonder if it's possible to flatten the taxonomy a bit. I think I prefer
 {{{
 import flashproxy
 flashproxy.parse_addr_spec()
 }}}
 over
 {{{
 from flashproxy.common.util import parse_addr_spec
 parse_addr_spec()
 }}}
 Three levels just feels a bit too deep. I'd lean toward packages
 `flashproxy` and `flashproxy.fac`. What do you think?

 I think it's fine to ship the facilitator library functions in the client
 tarball, so there's no need for a split between common and non-common
 functions.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list