[tor-bugs] #9801 [Tor]: options_act thinks options have changed that haven't

[Tor Bug Tracker & Wiki]

#9801: options_act thinks options have changed that haven't
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  needs_information
     Priority:  normal       |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor          |    Version:  Tor: 0.2.4.17-rc
   Resolution:               |   Keywords:  tor-client
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_information
 * keywords:   => tor-client


Comment:

 I just started a tor 0.2.4 client with a torrc consisting of a single
 ExcludeNodes line, and gave it a SIGHUP.  It didn't tell me "Changed to
 using entry guards or bridges, or changed preferred or excluded node
 lists. Abandoning previous circuits.".

 The relevant code here is:
 {{{
     if ((options->UseEntryGuards && !old_options->UseEntryGuards) ||
         options->UseBridges != old_options->UseBridges ||
         (options->UseBridges &&
          !config_lines_eq(options->Bridges, old_options->Bridges)) ||
         !routerset_equal(old_options->ExcludeNodes,options->ExcludeNodes)
 ||
         !routerset_equal(old_options->ExcludeExitNodes,
                          options->ExcludeExitNodes) ||
         !routerset_equal(old_options->EntryNodes, options->EntryNodes) ||
         !routerset_equal(old_options->ExitNodes, options->ExitNodes) ||
         options->StrictNodes != old_options->StrictNodes) {
       log_info(LD_CIRC,
                "Changed to using entry guards or bridges, or changed "
                "preferred or excluded node lists. "
                "Abandoning previous circuits.");
 }}}

 The likeliest way I could see for a bug like this to happen would be if
 there's some code in Tor that's rewriting those options between SIGHUPs,
 or making them seem unequal every time we parse them; the next likeliest
 way would be if there's something making the torrc file look differently
 every time we reload it.  (Any thoughts?)

 If there are any ideas about how to reproduce this -- for example, what I
 need to put in my torrc to see this behavior -- that would help debug this
 one.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9801#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online