[tor-bugs] #9790 [TorBrowserButton]: The Torbutton startup observer component is sometimes not initialized

[Tor Bug Tracker & Wiki]

#9790: The Torbutton startup observer component is sometimes not initialized
----------------------------------+-----------------------
     Reporter:  gk                |      Owner:  mikeperry
         Type:  defect            |     Status:  new
     Priority:  critical          |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+-----------------------

Comment (by gk):

 The interesting thing is this: The SSL Observatory code does not catch the
 exception which is happening due to missing ctypes. You ususally see
 something like
 {{{
 Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code:
 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
 Source File: ~/tor-browser_en-US/Data/profile/extensions/https-
 everywhere at eff.org/components/ssl-observatory.js
 Line: 29
 }}}
 in the error console. However, I wrapped the whole startup observer
 component in a try-catch block to see what is happening and got:
 {{{
 Error: [Exception... "Component returned failure code: 0x80520012
 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult:
 "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: ~/tor-
 browser_en-US/Data/profile/extensions/https-everywhere at eff.org/components
 /ssl-observatory.js :: <TOP_LEVEL> :: line 29"  data: no]
 Source File: ~/tor-browser_en-
 US/Data/profile/extensions/torbutton at torproject.org.xpi!/components
 /startup-observer.js
 Line: 235
 }}}
 when the info message showed up in the error console.
 This is pretty crazy and dangerous. Wrapping the offending SSL Observatory
 code in a try-catch-block might solve this bug. I am going to test that
 idea shortly.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9790#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online