[tor-bugs] #8510 [Tor]: Add useful Hidden Service related events to the Tor control port

[Tor Bug Tracker & Wiki]

#8510: Add useful Hidden Service related events to the Tor control port
-------------------------+----------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:  task     |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: unspecified
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs controller needs-proposal
Actual Points:           |  Parent ID:  #8993
       Points:           |
-------------------------+----------------------------------------------

Comment (by asn):

 Initial review. Haven't tested yet. I'd like to review again.

 - Nitpicking, but the error message ''Unknown directory'' is not a
 `LongName` as the spec indicates.

 - Hm, `if (hs_dir_node) {`. Is `!hs_dir_node` possible in that code? If
 yes, it should have an `else` clause to initialize `hs_dir` to a helpful
 string (it's currently printed as `NULL` in
 `control_event_hs_descriptor_requested()`). If no, then maybe it should be
 an `assert`?

 - Unittests would be awesome!

 Other than that, code looks sane.  Will need to test it to see it in
 action though.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8510#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online