[tor-bugs] #9645 [Tor]: Tor client goes berserk downloading microdescriptors forever, if you rm -rf its datadir

[Tor Bug Tracker & Wiki]

#9645: Tor client goes berserk downloading microdescriptors forever, if you rm -rf
its datadir
------------------------+-------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-------------------------------------
Changes (by nickm):

 * keywords:  tor-client => tor-client 024-backport


Comment:

 Replying to [comment:9 arma]:
 > Are we likely to try writing them again later when we reform our journal
 file? Are there bugs there?

 I *believe* that's the behavior, but I'm far from certain.  There could
 indeed be bugs, but since this is the same logic we use for
 microdescriptors in the journal, I don't think it's super likely.

 We'll only try once, since if we attempt to write a microdescriptor to the
 cache when rebuilding the cache, but the write fails, we then set the
 no_save =1 flag on the md.

 > I was about to merge bug9645 into maint-0.2.4 for the new release when I
 realized it's the sort of thing that will produce weird edge cases. Maybe
 it's best to let it bake in master for a while before backporting it (or
 deciding not to).

 Sounds good, especially given mr-4's "It didn't explode" report.  Merging
 this branch (my bug9645) to master and marking for 0.2.4 backport.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9645#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online