[tor-bugs] #1376 [Tor]: router_rebuild_store() uses a needless tmp file

[Tor Bug Tracker & Wiki]

#1376: router_rebuild_store() uses a needless tmp file
-------------------------+--------------------------------
     Reporter:  nickm    |      Owner:  pranavrc
         Type:  defect   |     Status:  needs_review
     Priority:  trivial  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:  Tor: 0.2.2.35
   Resolution:           |   Keywords:  easy tor-client
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by Ry):

 If we assume we're always going to have `.tmp` as our added extension we
 could write our own temp file with a random string and after a call we can
 ensure the temp file wasn't modified. Could then verify that the tempfile
 does get modified if we don't set the flag. It's quite flakey though but
 better than nothing I guess?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1376#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online