[tor-bugs] #9639 [Tor]: massive memory leak when starting tor in the absence of /var/lib/tor

[Tor Bug Tracker & Wiki]

#9639: massive memory leak when starting tor in the absence of /var/lib/tor
------------------------+---------------------------------
     Reporter:  mr-4    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:
    Component:  Tor     |    Version:  Tor: 0.2.4.14-alpha
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+---------------------------------

Comment (by mr-4):

 Replying to [comment:5 nickm]:
 > Branch "bug9639" in my public repository is based on maint-0.2.4 and is
 likely to solve the leak, though not the related "goes crazy" issue
 (#9645).
 Am I right in thinking that the following code is the whole fix:
 {{{
 --- a/src/or/microdesc.c
 +++ b/src/or/microdesc.c
 @@ -213,6 +213,7 @@ microdescs_add_list_to_cache(microdesc_cache_t *cache,
      if (fd < 0) {
        log_warn(LD_DIR, "Couldn't append to journal in %s: %s",
                 cache->journal_fname, strerror(errno));
 +      SMARTLIST_FOREACH(descriptors, microdesc_t *, md,
 microdesc_free(md));
        return NULL;
      }
    }
 }}}

 If so, then I assume tor will still try to loop (as in #9645), but without
 the associated memory leak, right?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9639#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online