[tor-bugs] #9400 [Tor]: double-close in socketpair replacement function on failure

[Tor Bug Tracker & Wiki]

#9400: double-close in socketpair replacement function on failure
------------------------+------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by nickm):

 031e695aa50f24000ec112d535636807167be436 is cosmetic; that's how we're
 supposed to be handling invalid sockets throughout our code (because on
 windows the correct check is "== -1").

 1f4dcc957bc8006addcfae4560ab4f8888781ded is the bugfix.... or at least, it
 was supposed to be.  Sorry there!   I've added a new commit to have the
 actual fix. :/ (That's the double-close.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9400#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online