[tor-bugs] #5605 [Tor]: Why is control_ports_write_to_file() called from options_act_reversible()?

[Tor Bug Tracker & Wiki]

#5605: Why is control_ports_write_to_file() called from options_act_reversible()?
------------------------+------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: unspecified
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  easy tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by Ry):

 https://github.com/Ryman/tor/tree/bug5605

 I didn't update the signatures for options_act* to take the new options as
 parameter as there are a lot of calls that aren't passing options down and
 are relying on get_options() to make their decisions. There's no real
 benefit to the codebase I think as options_act isn't really called
 anywhere else currently.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5605#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online