[tor-bugs] #9639 [Tor]: massive memory leak when starting tor in the absence of /var/lib/tor

[Tor Bug Tracker & Wiki]

#9639: massive memory leak when starting tor in the absence of /var/lib/tor
------------------------+---------------------------------
     Reporter:  mr-4    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:
    Component:  Tor     |    Version:  Tor: 0.2.4.14-alpha
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+---------------------------------

Comment (by arma):

 {{{
 /** As microdescs_add_to_cache, but takes a list of microdescriptors
 instead of
  * a string to decode.  Frees any members of <b>descriptors</b> that it
 does
  * not add. */
 smartlist_t *
 microdescs_add_list_to_cache(microdesc_cache_t *cache,
                              smartlist_t *descriptors, saved_location_t
 where,
                              int no_save)
 {
 [...]
     if (fd < 0) {
       log_warn(LD_DIR, "Couldn't append to journal in %s: %s",
                cache->journal_fname, strerror(errno));
       return NULL;
     }
 }}}

 sure doesn't look like it's freeing any descriptors before returning. I
 guess this leak could happen when you run out of disk space for your
 datadir too, yes?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9639#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online