[tor-bugs] #9330 [Pluggable transport]: Pluggable Transports on windows are killed with ProcessTerminate

[Tor Bug Tracker & Wiki]

#9330: Pluggable Transports on windows are killed with ProcessTerminate
------------------------------+--------------------------------------------
     Reporter:  yawning       |      Owner:  asn
         Type:  defect        |     Status:  new
     Priority:  normal        |  Milestone:
    Component:  Pluggable     |    Version:  Tor: unspecified
  transport                   |   Keywords:  pt, win32, pluggable transport
   Resolution:                |  Parent ID:
Actual Points:                |
       Points:                |
------------------------------+--------------------------------------------

Comment (by yawning):

 tor.exe spawns my child with CREATE_BREAKAWAY_FROM_JOB.

 My child calls CreateJobObject.

 My child spawns children of it's own, and assigns them to the Job Object.

 tor.exe notifies it's child of a graceful shutdown somehow (DllMain
 probably not an option because a lot of PTs are Python scripts, might be a
 way to do it, don't care, it's orthogonal to this discussion).

 My child does it's cleanup, and terminates Job Object (the better thing to
 do would be to propagate the graceful termination request).

 Not seeing the "must".  *shrugs*  Maybe it would be better that tor.exe
 creates the group so that it has a way of reaping children via terminating
 the Job Object if it absolutely needs them to die.  Don't know, that's a
 design decision that's not up to me.

 What "must" be done is that pt-spec (that I didn't write mind you) needs
 to explicitly specify how this is to be done on Windows vs the rest of the
 supported platforms (When working on this, which was a while ago, I did
 look into using GetMessage, but it wasn't a workable solution for me at
 the time because it required modifying the PT spec, and tor.exe.  It seems
 like the cleanest approach that's usable from the most languages.).  For
 this I will defer to people that actually know the correct "windows" way
 of doing things is and implement what they came up with.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9330#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online