[tor-bugs] #9860 [Tor]: junk log messages every time SETCONF changes the set of ORPorts

[Tor Bug Tracker & Wiki]

#9860: junk log messages every time SETCONF changes the set of ORPorts
-------------------------+-------------------------------------------------
     Reporter:  zwol     |      Owner:
         Type:  defect   |     Status:  new
     Priority:  trivial  |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor      |    Version:  Tor: 0.2.4.17-rc
   Resolution:           |   Keywords:  tor-client tor-relay easy
Actual Points:           |  deferrable
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by rl1987):

 Replying to [comment:2 nickm]:

 > The simplest workaround for the "opening log" one would be to only do
 the log-reopening dance in options_act_reversible if the log options have
 really changed.

 How do we know if the options have changed? We can't use `tor_memcmp()` to
 compare `or_options_t` structs since memory alignment of fields may differ
 even if individual field values are equal. Is there another way?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9860#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online