[tor-bugs] #9965 [Flashproxy]: allow browser proxy config values to be overridden by other js

[Tor Bug Tracker & Wiki]

#9965: allow browser proxy config values to be overridden by other js
-----------------------------+-----------------
     Reporter:  infinity0    |      Owner:  dcf
         Type:  enhancement  |     Status:  new
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by dcf):

 Replying to [comment:2 infinity0]:
 > aha, I overlooked the query string params. But that only lets the
 visitor control the params, it doesn't let the site owner set the
 defaults. (And the latter is more likely to want to do that anyway.)
 >
 > If we wanted to support that, I think it would be an easy edit - in
 flashproxy.js, change all the constants to instead do a conditional
 define, like this:
 >
 > {{{
 > var DEFAULT_FACILITATOR_URL = DEFAULT_FACILITATOR_URL || "https://fp-
 facilitator.org/";
 > }}}
 >
 > Then in the `/* overrides */` part, the site owner can set their own
 value, which flashproxy will then read and honour.

 Okay, making the variables overridable in this way is fine with me.

 In general, it ''is'' the site owner, and not the visitor, who sets the
 query string parameters. They put the parameters in their HTML, and all
 their visitors use it automatically. A good example is at
 https://crypto.stanford.edu/flashproxy/#badge-howto, where it shows you
 how to set the `cookierequired` parameter for all your web site visitors.
 You can set `facilitator`, for example, in the same way.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9965#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online