[tor-bugs] #9976 [Flashproxy]: flashproxy-client needs to pass args to reg-methods

[Tor Bug Tracker & Wiki]

#9976: flashproxy-client needs to pass args to reg-methods
----------------------------+-----------------
     Reporter:  infinity0   |      Owner:  dcf
         Type:  defect      |     Status:  new
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+-----------------

Comment (by infinity0):

 I'm ok with the single-command line idea, but it could potentially lead to
 even worse double-escaping :p (or even worse, non-functionality, depending
 on whether Tor parses the ClientTransportPlugin line coherently).

 We can use http://docs.python.org/2/library/shlex.html to split the line.
 Implementation-wise it would be simpler to use python's `%()s` syntax, so
 then we'd get something like:

 {{{
 flashproxy-client --register-command='reg-twitter --extra-twitter-
 specific-flags %(fp_options) %(address)'
 }}}

 If feasible, I'd prefer to keep things simple and keep all the
 potentially-inheritable options in a single %(fp_options) variable. If the
 reg-method gets non-sensical options (e.g. facilitator URL for reg-email)
 it should just ignore them. (We could move this code to the common
 library, so anything written in python can do this with ease.)

 Some more possibilities:

 * automatically append "%(inherit_options) %(address)" to any command
 string that doesn't have a % character.
 * automatically convert "xxx yyy zzz" to "flashproxy-reg-xxx yyy zzz" if
 "xxx" doesn't exist on the PATH.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9976#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online