[tor-bugs] #9925 [Tor]: Directory Authorities can crash client/relay

[Tor Bug Tracker & Wiki]

#9925: Directory Authorities can crash client/relay
------------------------+--------------------------------
     Reporter:  sysrqb  |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 >  Or is this a "we'll get it next time"?

 It's a "we'll get it next time."  But really, it won't work, since if we
 get a descriptor with the right digest, then -- barring sha1 collisions --
 we'll get the same descriptor we already had: the one with the wrong
 identity key.

 Another option might be to mark the descriptor as "just don't download
 this."  Possibly that's a better idea.

 > Is there a reason to pass seen_descriptor_digests as a parameter?

 It needs to stay around between invocations of
 routerstatus_parse_entry_from_string, since each call to
 routerstatus_parse_entry_from_string will parse only a single entry, but
 we want to check (as we parse each entry) whether we have seen *any*
 duplicate entries before.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9925#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online