[tor-bugs] #9349 [Flashproxy]: flashproxy facilitator: Allow clients to specify transports

[Tor Bug Tracker & Wiki]

#9349: flashproxy facilitator: Allow clients to specify transports
----------------------------+--------------------------
     Reporter:  asn         |      Owner:  dcf
         Type:  task        |     Status:  needs_review
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:  #7167
       Points:              |
----------------------------+--------------------------

Comment (by dcf):

 Replying to [comment:10 dcf]:
 > Replying to [comment:9 asn]:
 > > For "release early; release often" purposes, I pushed a branch with
 changes on the client-side applications to support pluggable transports
 and the new client registrations.
 > >
 > > It can be found in
 `https://git.torproject.org/user/asn/flashproxy.git` under branch
 `bug9349_client_side`. I've only briefly tested it.
 >
 > Thanks George, you're awesome.
 >
 > The `--help` test for `--transport` should say what the default value
 is.
 >
 > Set
 > {{{
 >     transport = DEFAULT_TRANSPORT
 > }}}
 > in the global options class, not in the code just before option parsing.
 >
 > {{{
 > +    transport_part = [""] # default to empty string
 > }}}
 > I think that should rather be an empty list; otherwise I'm pretty sure
 the helpers get an extra empty argument.
 >
 > I saw you moved some duplicated code into a module flashproxy_reg_utils.
 Please see #6810 for more about reducing code duplication. I'm afraid
 doing it this way will break `make install`. Alexandre tried breaking out
 a module in #6810, and it didn't quite work. So if you can separate the
 deduplication part of the patch, I think it's better for the purpose of
 this ticket.

 I squashed and rebased and made these suggested changes in
 https://git.torproject.org/user/dcf/flashproxy.git branch
 bug9349_client_side. Currently these four commits:
 {{{
 a86d340 Add --transport to flashproxy-client.
 9a02028 Add --transport option to reg programs.
 3ec8472 Send client-transport=websocket in registrations.
 c3029c9 Tolerate other URL parameters in client regisration lines.
 }}}
 This code is using the newest registration syntax,
 {{{
 client=<addr:port>&client-transport=websocket
 }}}
 My hope is to merge these client changes right away, because then the
 changes to the client are done. c3029c9 is a small change to facilitator-
 reg-daemon so it doesn't freak out at the `client-transport` field. It's
 sufficient to make the reg-url step in comment:40 work with no further
 code changes, it remains backward compatible, and it's forward compatible
 with what we plan to implement wrt to multiple registrations.

 That is, I expect c3029c9 to be replaced by other code soon, but I'd like
 to merge and deploy it now, so that we can merge the client changes and
 have one less thing to worry about.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9349#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online