[tor-bugs] #9934 [Tor]: Add control command to drop guard nodes

[Tor Bug Tracker & Wiki]

#9934: Add control command to drop guard nodes
-----------------------------+------------------------------------------
     Reporter:  ra           |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  minor        |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client guards controller
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------------------
Changes (by nickm):

 * status:  new => needs_revision
 * keywords:   => tor-client guards controller
 * milestone:   => Tor: 0.2.5.x-final


Comment:

 Quick notes:
   * Should there be an ability to drop a specific guard?
   * Right now, if you call this command with arguments, they all get
 ignored.  That can't be right.
   * The loop is strangely structured, given that "i" is never incremented.
 Perhaps it would make more sense to do `while (smartlist_len(entryguards)
 { entryguard = smartlist_get(entryguards, 0); ... }`?
   * Remember that in C, "void fn()" is a function that takes an
 unspecified number of arguments. If you need to write a function that
 takes no arguments, you have to say "void fn(void)".
   * Every function should be documented.
   * Perhaps we should explain briefly what the intended use case of this
 command is.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9934#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online