[tor-bugs] #9349 [Flashproxy]: flashproxy facilitator: Allow clients to specify transports

[Tor Bug Tracker & Wiki]

#9349: flashproxy facilitator: Allow clients to specify transports
----------------------------+--------------------------
     Reporter:  asn         |      Owner:  dcf
         Type:  task        |     Status:  needs_review
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:  #7167
       Points:              |
----------------------------+--------------------------

Comment (by infinity0):

 As I understand, there are 3 input sources to the facilitator:

 - GET / for proxy polls, going through facilitator.cgi
 - POST / for cleartext client registrations, going through facilitator.cgi
 - various rendezvous channels for encrypted client registrations, going
 through facilitator-reg-daemon

 The patch for the newline-based client registration syntax only changes
 facilitator-reg-daemon - so am I correct in thinking that facilitator.cgi
 also needs to be updated?

 In that case, we should probably put the registration-parsing code in
 fac.py. I'll be proceeding with this.

 Merging #6810 first would also make this easier to implement on the client
 side - at the moment, asn's bug9349_client branch has some duplicated
 code. But we can do that later, since what we're doing with the
 facilitator/proxy is backwards-compatible with old clients.

 And to refresh what was said before, we'll also need to change the proxy
 to check that the facilitator's response sets transport=websocket for both
 the client and relay. To match the urlparam syntax, I'd suggest changing
 it to client-addr=$addr&client-transport=$transport, rather than the
 current client-$transport=$addr

 I think that's all the remaining things.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9349#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online