[tor-bugs] #9870 [Tor]: Redundant "Your log may contain sensitive information" messages

[Tor Bug Tracker & Wiki]

#9870: Redundant "Your log may contain sensitive information" messages
--------------------+------------------------------------
 Reporter:  arma    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 0.2.5.1-alpha when I start it with safelogging 0 and an info-level log
 says
 {{{
 Oct 01 21:02:26.050 [warn] Your log may contain sensitive information:
 you're logging more than "notice". Please log safely. Don't log unless it
 serves an important reason, and overwrite the log afterwards.
 Oct 01 21:02:26.050 [notice] Not disabling debugger attaching for
 unprivileged users.
 Oct 01 21:02:26.050 [warn] Your log may contain sensitive information -
 you disabled SafeLogging. Please log safely. Don't log unless it serves an
 important reason. Overwrite the log afterwards.
 }}}

 A) Is there any reason that first "may contain sensitive information" log
 is in options_act_reversible, and the second in options_act? I would think
 they should both be in options_act.

 B) I think we should make only one log line show up if they both would.
 I'd pick the second one.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9870>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online