[tor-bugs] #9570 [TorBrowserButton]: Many changes to private browsing code of Firefox happened since 17esr out

[Tor Bug Tracker & Wiki]

#9570: Many changes to private browsing code of Firefox happened since 17esr out
----------------------------------+----------------------------------------
     Reporter:  cypherpunks       |      Owner:  mikeperry
         Type:  defect            |     Status:  needs_revision
     Priority:  normal            |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:  ff24-esr, MikePerry201311R
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+----------------------------------------
Changes (by mikeperry):

 * status:  needs_review => needs_revision


Comment:

 I went ahead and merged this because it is an improvement and will help us
 test FF24 sooner, but I have the following questions and concerns:

 1. For the image cache stuff: Do we need move that call up to before the
 point where we try to close any windows? On the one hand, we don't want to
 miss clearing it if there are no private windows currently open (because
 we just closed them). On the other hand, we don't want to let any windows
 load any images after we've cleared the image cache.. I'm also surprised
 that closing all windows doesn't clear the private browsing data + caches
 automatically. Shouldn't it?
 1. Related: We're sure there can be only two image caches, right?
 1. For the nsIContentPrefService2 clearing code, do we need to get
 contexts for both private and non-private windows here too? It sounds like
 we might?
 1. For your comment about {private: true} above OpenBrowserWindow(), that
 sounds like it might be our fix for #8400, yes? If we set that arg based
 on the torbutton pref extensions.torbutton.block_disk, perhaps that will
 solve #8400, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9570#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online