[tor-bugs] #9454 [TorBrowserButton]: The nsIPluginTag Interface was changed, Torbutton is broken for next Firefox ESR

[Tor Bug Tracker & Wiki]

#9454: The nsIPluginTag Interface was changed, Torbutton is broken for next
Firefox ESR
----------------------------------+----------------------------------------
     Reporter:  cypherpunks       |      Owner:  mikeperry
         Type:  defect            |     Status:  needs_review
     Priority:  normal            |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:  ff24-esr, MikePerry201311R
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+----------------------------------------

Comment (by mikeperry):

 Ok, I've gone ahead and merged this. The check for the existence of
 "enabledState" seems sane to me.

 cypherpunks: We need to use this attribute to be consistent with the
 individual plugin enable/disable UI in the Tools->Addons->Plugins pane,
 and to ensure the appropriate observer notifications get fired in both
 cases.

 However, I am curious why mcs chose to check the state before setting the
 attribute? Does this reduce spurious 'xpcom-category-entry-added' observer
 events? Or some other reason? If it is in fact needed for some reason, we
 should comment the code with that reason.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9454#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online