[tor-bugs] #10088 [Tor]: Allow tor helpers to use JobObjects by setting CREATE_BREAKAWAY_FROM_JOB (Windows-only)

[Tor Bug Tracker & Wiki]

#10088: Allow tor helpers to use JobObjects by setting CREATE_BREAKAWAY_FROM_JOB
(Windows-only)
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by dcf):

 Replying to [comment:5 infinity0]:
 > If my suspicion is correct, then dcf if you run your tests from
 [ticket:10006#comment:28] with a pristine unhacked tor.exe, it will still
 work. (I don't have access to a Vista/7 machine to do this test myself.
 And be sure to use a post-"removed-workaround" commit like
 33f090961c1e5d0587938a169c9d8107133ff646.)

 I tested with
  * bundle [https://gitweb.torproject.org/pluggable-
 transports/bundle.git/commit/d4632105e10e56e3d88c75fbc3d7bc2f78dfd924
 2.4.17-beta-2-obfs_flash1 d4632105e10e56e3d88c75fbc3d7bc2f78dfd924]
  * pyptlib
 [https://github.com/infinity0/pyptlib/commit/534d81979b628a0e7ad09377b33c78cf200c5b97
 w32-subproc 534d81979b628a0e7ad09377b33c78cf200c5b97]
  * obfs-flash [https://github.com/infinity0/obfs-
 flash/commit/951616c9789689d572d52ee2764b0a3ca2bd0bb3 fix-w32-kill
 951616c9789689d572d52ee2764b0a3ca2bd0bb3]
 (I changed `PYPTLIB_TAG` and `OBFS_FLASH_TAG` in bundle/Makefile before
 running make, leaving it as unstaged changes.)

 Here is the compiled bundle:
  * https://people.torproject.org/~dcf/pt-bundle/2.4.17-beta-2-obfs-
 flash20131112/

 This configuration works for me. All the subprocesses are destroyed. The
 first time I tried it, I got a "Vidalia has encountered and error and
 needs to close," but not the second time, so it was probably unrelated. To
 be clear, this is with an unmodified tor.exe, not having
 `CREATE_BREAKAWAY_FROM_JOB` set.

 I hope this is what you wanted.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10088#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online