[tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

[Tor Bug Tracker & Wiki]

#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by infinity0):

 Replying to [comment:24 dcf]:
 > I don't think we should grep the version from ChangeLog. [..] (I don't
 think of ChangeLog as being something that has to be kept in sync, because
 nothing breaks if it's not.)

 There's some precedence for this - Debian packaging only defines the
 version from debian/changelog and nowhere else, and debian build tools
 read this as the canonical place to get the version string. (It's doesn't
 matter if you don't sync it, as it will just use the old version
 automatically, nothing "breaks" as such, and it's a good habit to update
 the ChangeLog when appropriate.)

 I could reduce the code duplication of the sed script by, instead of
 having a VERSION file as you suggest, turn it into a version.sh that
 contains the sed script and call it from the Makefile/setup.py. How's
 that? If not, no worries, I'll just do the VERSION file.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online